Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 05f1b12f authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

net: x25: remove null checks on arrays calling_ae and called_ae 



dtefacs.calling_ae and called_ae are both 20 element __u8 arrays and
cannot be null and hence are redundant checks. Remove these.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c24acf03

net/x25/af_x25.c

+0 −4
Original line number Diff line number Diff line
@@ -1500,12 +1500,8 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) 
			goto out_dtefac_release;

		if (dtefacs.calling_len > X25_MAX_AE_LEN)

			goto out_dtefac_release;

		if (dtefacs.calling_ae == NULL)

			goto out_dtefac_release;

		if (dtefacs.called_len > X25_MAX_AE_LEN)

			goto out_dtefac_release;

		if (dtefacs.called_ae == NULL)

			goto out_dtefac_release;

		x25->dte_facilities = dtefacs;

		rc = 0;

out_dtefac_release: