Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0597e818 authored by Viresh Kumar's avatar Viresh Kumar Committed by Rafael J. Wysocki
Browse files

PM / OPP: Add opp_rcu_lockdep_assert() to _find_device_opp() 



_find_device_opp() should be called with rcu-read lock or
dev_opp_list_lock held. Add the opp_rcu_lockdep_assert() check to make
sure caller have taken appropriate locks.

Fix comment over the routine as well.

Suggested-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 4a3a1353

drivers/base/power/opp/core.c

+7 −3
Original line number Diff line number Diff line
@@ -81,14 +81,18 @@ static struct device_opp *_managed_opp(const struct device_node *np) 
 * Return: pointer to 'struct device_opp' if found, otherwise -ENODEV or

 * -EINVAL based on type of error.

 *

 * Locking: This function must be called under rcu_read_lock(). device_opp

 * is a RCU protected pointer. This means that device_opp is valid as long

 * as we are under RCU lock.

 * Locking: For readers, this function must be called under rcu_read_lock().

 * device_opp is a RCU protected pointer, which means that device_opp is valid

 * as long as we are under RCU lock.

 *

 * For Writers, this function must be called with dev_opp_list_lock held.

 */

struct device_opp *_find_device_opp(struct device *dev)

{

	struct device_opp *dev_opp;



	opp_rcu_lockdep_assert();



	if (IS_ERR_OR_NULL(dev)) {

		pr_err("%s: Invalid parameters\n", __func__);

		return ERR_PTR(-EINVAL);