Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 058eec41 authored by Michal Schmidt's avatar Michal Schmidt Committed by David S. Miller
Browse files

bnx2x: remove zeroing of dump data buffer 



There is no need to initialize the dump data with zeros.
data is allocated with vzalloc, so it's already zero-filled.

More importantly, the memset is harmful, because dump->len (the length
requested by userspace) can be bigger than the allocated buffer (whose
size is determined by asking the driver's .get_dump_flag method).

Signed-off-by: default avatarMichal Schmidt <mschmidt@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e02010ad

drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c

+0 −2
Original line number Diff line number Diff line
@@ -985,8 +985,6 @@ static int bnx2x_get_dump_data(struct net_device *dev, 
	struct bnx2x *bp = netdev_priv(dev);

	struct dump_header dump_hdr = {0};



	memset(p, 0, dump->len);



	/* Disable parity attentions as long as following dump may

	 * cause false alarms by reading never written registers. We

	 * will re-enable parity attentions right after the dump.