Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 057f02a3 authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

[SCSI] osd: checking NULL instead of ERR_PTR() 



bio_map_kern() returns ERR_PTRs on failure and never returns NULL.

[jejb: remove redundant unlikely spotted by Tobias Klauser]
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 6313e3c2

drivers/scsi/osd/osd_initiator.c

+2 −2
Original line number Diff line number Diff line
@@ -951,8 +951,8 @@ static int _osd_req_finalize_cdb_cont(struct osd_request *or, const u8 *cap_key) 
	/* create a bio for continuation segment */

	bio = bio_map_kern(req_q, or->cdb_cont.buff, or->cdb_cont.total_bytes,

			   GFP_KERNEL);

	if (unlikely(!bio))

		return -ENOMEM;

	if (IS_ERR(bio))

		return PTR_ERR(bio);



	bio->bi_rw |= REQ_WRITE;