Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0577010b authored by Harsh Shah's avatar Harsh Shah
Browse files

msm: camera: cdm: Fix false negative in streamoff 



Return value is not updated correctly in one of the if-else
cases, hence causing the function to return failure even for
success.

Change-Id: Ia1602b43589c232cf0d65cde7f56657643f9b3f1
Signed-off-by: default avatarHarsh Shah <harshs@codeaurora.org>
parent 65ad3cde

drivers/media/platform/msm/camera/cam_cdm/cam_cdm_core_common.c

+1 −0
Original line number Diff line number Diff line
@@ -338,6 +338,7 @@ int cam_cdm_stream_ops_internal(void *hw_priv, 
				}

			} else {

				client->stream_on = false;

				rc = 0;

				CAM_DBG(CAM_CDM,

					"Client stream off success =%d",

					cdm_hw->open_count);

drivers/media/platform/msm/camera/cam_cdm/cam_cdm_virtual_core.c

+4 −2
Original line number Diff line number Diff line
@@ -131,8 +131,10 @@ int cam_virtual_cdm_submit_bl(struct cam_hw_info *cdm_hw, 
				cdm_cmd->cmd[i].len, client->data.base_array,

				client->data.base_array_cnt, core->bl_tag);

			if (rc) {

				CAM_ERR(CAM_CDM, "write failed for cnt=%d:%d",

					i, req->data->cmd_arrary_count);

				CAM_ERR(CAM_CDM,

					"write failed for cnt=%d:%d len %u",

					i, req->data->cmd_arrary_count,

					cdm_cmd->cmd[i].len);

				break;

			}

		} else {