Commit 05395a3d authored Dec 06, 2009 by Mauro Carvalho Chehab

V4L/DVB (13576): ir-common: fix an oops caused by the usage of an initialized drvdata



As reported by Sander Eikelenboom <linux@eikelemboon.it>:

> Tried to update my v4l-dvb modules today, but got a bug with my pinnacle
> card, seems to be related to the recent changes in the ir code.
>
> Dec  5 23:30:25 security kernel: [    5.735698] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> Dec  5 23:30:25 security kernel: [    5.735716] IP: [<ffffffffa00997be>] :ir_common:ir_input_free+0x26/0x3e

Thanks-to: Sander Eikelenboom <linux@eikelemboon.it> for reporting and testing the fix.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent b779974b

drivers/media/common/ir-keytable.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -419,6 +419,9 @@ void ir_input_free(struct input_dev *dev)
		{
		struct ir_scancode_table *rc_tab = input_get_drvdata(dev);

		if (!rc_tab)
		return;

		IR_dprintk(1, "Freed keycode table\n");

		rc_tab->size = 0;