Commit 0514e9ac authored May 16, 2011 by Axel Lin Committed by Liam Girdwood May 27, 2011

mfd: Fix off-by-one value range checking for tps65910_i2c_write



If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>

parent 4aa922c0

drivers/mfd/tps65910.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -71,7 +71,7 @@ static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
		u8 msg[TPS65910_MAX_REGISTER + 1];
		int ret;

		if (bytes > (TPS65910_MAX_REGISTER + 1))
		if (bytes > TPS65910_MAX_REGISTER)
		return -EINVAL;

		msg[0] = reg;