Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04b54e8f authored by Aaron Armstrong Skomra's avatar Aaron Armstrong Skomra Committed by Greg Kroah-Hartman
Browse files

HID: wacom: leds: Don't try to control the EKR's read-only LEDs 

commit 74aebed6dc13425233f2224668353cff7a112776 upstream.

Commit a50aac71 introduces 'led.groups' and adds EKR support
for these groups. However, unlike the other devices with LEDs,
the EKR's LEDs are read-only and we shouldn't attempt to control
them in wacom_led_control().

See bug: https://sourceforge.net/p/linuxwacom/bugs/342/



Fixes: a50aac71 ("HID: wacom: leds: dynamically allocate LED groups")
Signed-off-by: default avatarAaron Armstrong Skomra <aaron.skomra@wacom.com>
Reviewed-by: default avatarJason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5abb9cd4

drivers/hid/wacom_sys.c

+3 −0
Original line number Original line Diff line number Diff line
@@ -712,6 +712,9 @@ static int wacom_led_control(struct wacom *wacom) 
	if (!wacom->led.groups)

	if (!wacom->led.groups)

		return -ENOTSUPP;

		return -ENOTSUPP;





	if (wacom->wacom_wac.features.type == REMOTE)

		return -ENOTSUPP;



	if (wacom->wacom_wac.pid) { /* wireless connected */

	if (wacom->wacom_wac.pid) { /* wireless connected */

		report_id = WAC_CMD_WL_LED_CONTROL;

		report_id = WAC_CMD_WL_LED_CONTROL;

		buf_size = 13;

		buf_size = 13;