Commit 0386f7a9 authored Dec 13, 2020 by Bongsu Jeon Committed by Greg Kroah-Hartman Dec 29, 2020

nfc: s3fwrn5: Release the nfc firmware



[ Upstream commit a4485baefa1efa596702ebffd5a9c760d42b14b5 ]

add the code to release the nfc firmware when the firmware image size is
wrong.

Fixes: c04c674f ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip")
Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201213095850.28169-1-bongsu.jeon@samsung.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent bdf326bd

drivers/nfc/s3fwrn5/firmware.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -304,8 +304,10 @@ static int s3fwrn5_fw_request_firmware(struct s3fwrn5_fw_info *fw_info)
		if (ret < 0)
		return ret;

		if (fw->fw->size < S3FWRN5_FW_IMAGE_HEADER_SIZE)
		if (fw->fw->size < S3FWRN5_FW_IMAGE_HEADER_SIZE) {
		release_firmware(fw->fw);
		return -EINVAL;
		}

		memcpy(fw->date, fw->fw->data + 0x00, 12);
		fw->date[12] = '\0';