Commit 037f7416 authored Feb 23, 2016 by Janani Ravichandran Committed by Greg Kroah-Hartman Mar 11, 2016

staging: rdma: hfi1: Do not use | with a variable with value 0



mr->lkey has a value equal to 0. There is no need to combine it with
other things with | as for any value x, 0|x is always x.
Semantic patch used:
@@
expression x, e, e1;
statement S;
@@

  if (x == 0) {
    ... when != x = e1
        when != while(...) S
	when != for(...;...;...) S
(
* x |= e
|
* x | e
)
  ... when any
}

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7e43d4d2

drivers/staging/rdma/hfi1/keys.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -113,7 +113,7 @@ int hfi1_alloc_lkey(struct hfi1_mregion *mr, int dma_region)
		((((1 << (24 - hfi1_lkey_table_size)) - 1) & rkt->gen)
		<< 8);
		if (mr->lkey == 0) {
		mr->lkey \|= 1 << 8;
		mr->lkey = 1 << 8;
		rkt->gen++;
		}
		rcu_assign_pointer(rkt->table[r], mr);