Commit 0302899e authored Aug 04, 2011 by Julia Lawall Committed by David S. Miller Aug 04, 2011

drivers/ide/cy82c693.c: Add missing pci_dev_put

Pci_get_slot calls pci_dev_get, so pci_dev_put is needed before leaving the
function in the case where pci_get_slot is locally used.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
local idexpression x;
expression e;
@@

*x = pci_get_slot(...)
... when != true x == NULL
    when != pci_dev_put(x)
    when != e = x
    when != if (x != NULL) {<+... pci_dev_put(x); ...+>}
*return ...;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 89e9aad6

drivers/ide/cy82c693.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -141,6 +141,8 @@ static void cy82c693_set_pio_mode(ide_hwif_t hwif, ide_drive_t drive)
		pci_write_config_byte(dev, CY82_IDE_SLAVE_IOW, time_16);
		pci_write_config_byte(dev, CY82_IDE_SLAVE_8BIT, time_8);
		}
		if (hwif->index > 0)
		pci_dev_put(dev);
		}

		static void __devinit init_iops_cy82c693(ide_hwif_t *hwif)