Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0229c97f authored by Quinn Tran's avatar Quinn Tran Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: Fix unbound sleep in fcport delete path. 

[ Upstream commit c3b6a1d397420a0fdd97af2f06abfb78adc370df ]

There are instances, though rare, where a LOGO request cannot be sent out
and the thread in free session done can wait indefinitely. Fix this by
putting an upper bound to sleep.

Link: https://lore.kernel.org/r/20190912180918.6436-3-hmadhani@marvell.com


Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 80efde4b

drivers/scsi/qla2xxx/qla_target.c

+4 −0
Original line number Diff line number Diff line
@@ -572,6 +572,7 @@ static void qlt_free_session_done(struct work_struct *work) 


	if (logout_started) {

		bool traced = false;

		u16 cnt = 0;



		while (!ACCESS_ONCE(sess->logout_completed)) {

			if (!traced) {
@@ -581,6 +582,9 @@ static void qlt_free_session_done(struct work_struct *work) 
				traced = true;

			}

			msleep(100);

			cnt++;

			if (cnt > 200)

				break;

		}



		ql_dbg(ql_dbg_tgt_mgt, vha, 0xf087,