Commit 0228cd26 authored Oct 04, 2019 by Navid Emamdoost Committed by Greg Kroah-Hartman Nov 10, 2019

of: unittest: fix memory leak in unittest_data_add



[ Upstream commit e13de8fe0d6a51341671bbe384826d527afe8d44 ]

In unittest_data_add, a copy buffer is created via kmemdup. This buffer
is leaked if of_fdt_unflatten_tree fails. The release for the
unittest_data buffer is added.

Fixes: b951f9dc ("Enabling OF selftest to run without machine's devicetree")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1c2c7b43

drivers/of/unittest.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -933,6 +933,7 @@ static int __init unittest_data_add(void)
		of_fdt_unflatten_tree(unittest_data, NULL, &unittest_data_node);
		if (!unittest_data_node) {
		pr_warn("%s: No tree to attach; not running tests\n", __func__);
		kfree(unittest_data);
		return -ENODATA;
		}
		of_node_set_flag(unittest_data_node, OF_DETACHED);