Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0218d53a authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

[media] gscpa_ov519: Fix the bandwidth calc for enabling compression 



Somehow the code has ended up assuming 1400 packets/sec which of course
is wrong for usb1 devices like the ov511 cameras. usb1 only does 1000
(isoc) packets / sec.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 4d6454db

drivers/media/video/gspca/ov519.c

+2 −2
Original line number Diff line number Diff line
@@ -3683,8 +3683,8 @@ static void ov511_mode_init_regs(struct sd *sd) 
	/* Check if we have enough bandwidth to disable compression */

	fps = (interlaced ? 60 : 30) / (sd->clockdiv + 1) + 1;

	needed = fps * sd->gspca_dev.width * sd->gspca_dev.height * 3 / 2;

	/* 1400 is a conservative estimate of the max nr of isoc packets/sec */

	if (needed > 1400 * packet_size) {

	/* 1000 isoc packets/sec */

	if (needed > 1000 * packet_size) {

		/* Enable Y and UV quantization and compression */

		reg_w(sd, R511_COMP_EN, 0x07);

		reg_w(sd, R511_COMP_LUT_EN, 0x03);