Commit 0213424a authored Sep 12, 2016 by Ido Schimmel Committed by David S. Miller Sep 13, 2016

mlxsw: spectrum: Report port type according to operational speed



In case port isn't operational we shouldn't report the port type, but
instead return PORT_OTHER. This is consistent with most other drivers
that return PORT_OTHER when media type can't be determined.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4149b97f

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1828,7 +1828,6 @@ static int mlxsw_sp_port_get_settings(struct net_device *dev,
		mlxsw_sp_from_ptys_speed_duplex(netif_carrier_ok(dev),
		eth_proto_oper, cmd);

		eth_proto_oper = eth_proto_oper ? eth_proto_oper : eth_proto_cap;
		cmd->port = mlxsw_sp_port_connector_port(eth_proto_oper);

		if (autoneg_status == MLXSW_REG_PTYS_AN_STATUS_OK && eth_proto_lp)