Commit 01062465 authored Jan 04, 2006 by Arnd Bergmann Committed by Paul Mackerras Jan 09, 2006

[PATCH] spufs fix spu_acquire_runnable error path



When spu_activate fails in spu_acquire_runnable, the
state must still be SPU_STATE_SAVED, we were
incorrectly setting it to SPU_STATE_RUNNABLE.

Signed-off-by: Arnd Bergmann <arndb@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent 5ef8224a

arch/powerpc/platforms/cell/spufs/context.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -132,10 +132,10 @@ int spu_acquire_runnable(struct spu_context *ctx)

		if (ctx->state == SPU_STATE_SAVED) {
		ret = spu_activate(ctx, 0);
		ctx->state = SPU_STATE_RUNNABLE;
		}
		if (ret)
		goto out;
		ctx->state = SPU_STATE_RUNNABLE;
		}

		downgrade_write(&ctx->state_sema);
		/* On success, we return holding the lock */