Commit 00cf99ee authored Jun 25, 2013 by Wei Yongjun Committed by Thierry Reding Jun 25, 2013

pwm: renesas-tpu: fix return value check in tpu_probe()



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 99b82abb

drivers/pwm/pwm-renesas-tpu.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -410,10 +410,8 @@ static int tpu_probe(struct platform_device *pdev)
		}

		tpu->base = devm_ioremap_resource(&pdev->dev, res);
		if (tpu->base == NULL) {
		dev_err(&pdev->dev, "failed to remap I/O memory\n");
		return -ENXIO;
		}
		if (IS_ERR(tpu->base))
		return PTR_ERR(tpu->base);

		tpu->clk = devm_clk_get(&pdev->dev, NULL);
		if (IS_ERR(tpu->clk)) {