Commit 00b9a1f9 authored Mar 30, 2013 by Marc Kleine-Budde Committed by Greg Kroah-Hartman Mar 30, 2013

usb: chipidea: usbmisc: fix a potential race condition



This fixes a potential race condition where the ci13xxx_imx glue code
could be fast enough to call one of the usbmisc_ops before he got a
valid value on the static usbmisc pointer. To fix that we first set
usbmisc, then call usbmisc_set_ops().

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d48a24db

drivers/usb/chipidea/usbmisc_imx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -116,14 +116,14 @@ static int usbmisc_imx_probe(struct platform_device *pdev)
		return ret;
		}

		usbmisc = data;
		ret = usbmisc_set_ops(&imx6q_usbmisc_ops);
		if (ret) {
		usbmisc = NULL;
		clk_disable_unprepare(data->clk);
		return ret;
		}

		usbmisc = data;

		return 0;
		}