Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 006397c0 authored by Amadeusz Sławiński's avatar Amadeusz Sławiński Committed by Greg Kroah-Hartman
Browse files

ASoC: Intel: Fix use of potentially uninitialized variable 



commit 810f3b860850148788fc1ed8a6f5f807199fed65 upstream.

If ipc->ops.reply_msg_match is NULL, we may end up using uninitialized
mask value.

reported by smatch:
sound/soc/intel/common/sst-ipc.c:266 sst_ipc_reply_find_msg() error: uninitialized symbol 'mask'.

Signed-off-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@intel.com>
Link: https://lore.kernel.org/r/20190827141712.21015-3-amadeuszx.slawinski@linux.intel.com


Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c9780521

sound/soc/intel/common/sst-ipc.c

+2 −0
Original line number Diff line number Diff line
@@ -211,6 +211,8 @@ struct ipc_message *sst_ipc_reply_find_msg(struct sst_generic_ipc *ipc, 


	if (ipc->ops.reply_msg_match != NULL)

		header = ipc->ops.reply_msg_match(header, &mask);

	else

		mask = (u64)-1;



	if (list_empty(&ipc->rx_list)) {

		dev_err(ipc->dev, "error: rx list empty but received 0x%llx\n",