Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

FP5: Drop setting ro.opengles.version & ro.sf.lcd_density via init

Description

Drop setting ro.opengles.version & ro.sf.lcd_density via init on FP5.

Screenshots

Technical details

Gplay API needs OpenGL version in the requests.
On Qualcomm devices, this may get set very late from init script,
so it might cache an empty value for OpenGL version,
causing API to think device has no OpenGL support,
which prevents it from accessing a lot of apps.

Same would be the case for ro.sf.lcd_density as well.
set_density_by_fb in qcom script may set some odd default at boot time that could be cached by gplay api.
Value of ro.sf.lcd_density will be guaranteed by TARGET_SCREEN_DENSITY and will remain immutable.
Avoid dynamic reassignments for now. Use our hardcoded defaults and not stray from them.

Tests

adb shell getprop vendor.opengles.version should be empty.
adb shell getprop ro.opengles.version should be set.
Aurora store spoof manager exported config aurora_store_Fairphone_FP5.properties should have non-empty GL.Version field and value must match ro.opengles.version.

adb shell getprop vendor.display.lcd_density may be set, which is fine since we remove the part that reads this property to change ro.sf.lcd_density.
adb shell getprop ro.sf.lcd_density should be set same as adb shell getprop vendor.display.lcd_density.
Aurora store spoof manager exported config aurora_store_Fairphone_FP5.properties should have non-empty Screen.Density field and value must match ro.sf.lcd_density.

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/3707

10 commandments of code review

👪 ❤️ code review guidelines

Edited by Manu Suresh

Merge request reports

Loading