Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5a8e83b authored by Andy Hung's avatar Andy Hung Committed by Dan Pasanen
Browse files

Equalizer: Check value size for get preset name

Test: see CTS testAllEffectsEqualizer_CVE_2017_0401
Bug: 37536407
Change-Id: Ifa515dea10c9293022b7d0971d097f0bd727ac6c
(cherry picked from commit 8cf151a6)
parent 00b70199
Loading
Loading
Loading
Loading
+7 −0
Original line number Original line Diff line number Diff line
@@ -329,6 +329,13 @@ int equalizer_get_parameter(effect_context_t *context, effect_param_t *p,
                }
                }
                break;
                break;
        }
        }

        if (p->vsize < 1) {
            p->status = -EINVAL;
            android_errorWriteLog(0x534e4554, "37536407");
            break;
        }

        name = (char *)value;
        name = (char *)value;
        strlcpy(name, equalizer_get_preset_name(eq_ctxt, param2), p->vsize - 1);
        strlcpy(name, equalizer_get_preset_name(eq_ctxt, param2), p->vsize - 1);
        name[p->vsize - 1] = 0;
        name[p->vsize - 1] = 0;