Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a3b3abfa authored by Kunlei Zhang's avatar Kunlei Zhang
Browse files

hal: fix voip device selection is not proper after voice call stop 

In voip+voice concurrency case, when voip resume after voice call stop,
voip device still uses voice devices. This is due to in_call flag isn't
reset even if voice usecase doesn't exist.

Fix it by adding function to check voice usecase existence and get
correct device for non-voice usecases.

Change-Id: I39ba1092a0ab19c686baa1b80bb9913f64849590
parent eca77a2f

hal/msm8916/platform.c

+10 −6
Original line number Diff line number Diff line
@@ -4192,7 +4192,7 @@ snd_device_t platform_get_output_snd_device(void *platform, struct stream_out *o 
        * enforced audible (e.g. Camera shutter sound).

        */

        if ((mode == AUDIO_MODE_IN_CALL) ||

            voice_is_in_call(adev) ||

            voice_check_voicecall_usecases_active(adev) ||

            voice_extn_compress_voip_is_active(adev))

                is_active_voice_call = true;
@@ -4275,7 +4275,7 @@ snd_device_t platform_get_output_snd_device(void *platform, struct stream_out *o 
    }



    if ((mode == AUDIO_MODE_IN_CALL) ||

        voice_is_in_call(adev) ||

        voice_check_voicecall_usecases_active(adev) ||

        voice_extn_compress_voip_is_active(adev)) {

        if (devices & AUDIO_DEVICE_OUT_WIRED_HEADPHONE ||

            devices & AUDIO_DEVICE_OUT_WIRED_HEADSET ||
@@ -4651,8 +4651,10 @@ snd_device_t platform_get_input_snd_device(void *platform, 
    ALOGV("%s: enter: out_device(%#x) in_device(%#x) channel_count (%d) channel_mask (0x%x)",

          __func__, out_device, in_device, channel_count, channel_mask);

    if (my_data->external_mic) {

        if ((out_device != AUDIO_DEVICE_NONE) && ((mode == AUDIO_MODE_IN_CALL) || voice_is_in_call(adev) ||

            voice_extn_compress_voip_is_active(adev) || audio_extn_hfp_is_active(adev))) {

        if ((out_device != AUDIO_DEVICE_NONE) && ((mode == AUDIO_MODE_IN_CALL) ||

            voice_check_voicecall_usecases_active(adev) ||

            voice_extn_compress_voip_is_active(adev) ||

            audio_extn_hfp_is_active(adev))) {

            if (out_device & AUDIO_DEVICE_OUT_WIRED_HEADPHONE ||

               out_device & AUDIO_DEVICE_OUT_EARPIECE ||

               out_device & AUDIO_DEVICE_OUT_SPEAKER )
@@ -4666,8 +4668,10 @@ snd_device_t platform_get_input_snd_device(void *platform, 
    if (snd_device != AUDIO_DEVICE_NONE)

        goto exit;



    if ((out_device != AUDIO_DEVICE_NONE) && ((mode == AUDIO_MODE_IN_CALL) || voice_is_in_call(adev) ||

        voice_extn_compress_voip_is_active(adev) || audio_extn_hfp_is_active(adev))) {

    if ((out_device != AUDIO_DEVICE_NONE) && ((mode == AUDIO_MODE_IN_CALL) ||

        voice_check_voicecall_usecases_active(adev) ||

        voice_extn_compress_voip_is_active(adev) ||

        audio_extn_hfp_is_active(adev))) {

        if ((adev->voice.tty_mode != TTY_MODE_OFF) &&

            !voice_extn_compress_voip_is_active(adev)) {

            if (out_device & AUDIO_DEVICE_OUT_WIRED_HEADPHONE ||

hal/msm8974/platform.c

+10 −6
Original line number Diff line number Diff line
@@ -5489,7 +5489,7 @@ snd_device_t platform_get_output_snd_device(void *platform, struct stream_out *o 
        * enforced audible (e.g. Camera shutter sound).

        */

        if ((mode == AUDIO_MODE_IN_CALL) ||

            voice_is_in_call(adev) ||

            voice_check_voicecall_usecases_active(adev) ||

            voice_extn_compress_voip_is_active(adev))

                is_active_voice_call = true;
@@ -5613,7 +5613,7 @@ snd_device_t platform_get_output_snd_device(void *platform, struct stream_out *o 
    }



    if ((mode == AUDIO_MODE_IN_CALL) ||

        voice_is_in_call(adev) ||

        voice_check_voicecall_usecases_active(adev) ||

        voice_extn_compress_voip_is_active(adev) ||

        adev->enable_voicerx ||

        audio_extn_hfp_is_active(adev)) {
@@ -6097,8 +6097,10 @@ snd_device_t platform_get_input_snd_device(void *platform, 
    ALOGV("%s: enter: out_device(%#x) in_device(%#x) channel_count (%d) channel_mask (0x%x)",

          __func__, out_device, in_device, channel_count, channel_mask);

    if (my_data->external_mic) {

        if ((out_device != AUDIO_DEVICE_NONE) && ((mode == AUDIO_MODE_IN_CALL) || voice_is_in_call(adev) ||

            voice_extn_compress_voip_is_active(adev) || audio_extn_hfp_is_active(adev))) {

        if ((out_device != AUDIO_DEVICE_NONE) && ((mode == AUDIO_MODE_IN_CALL) ||

            voice_check_voicecall_usecases_active(adev) ||

            voice_extn_compress_voip_is_active(adev) ||

            audio_extn_hfp_is_active(adev))) {

            if (out_device & AUDIO_DEVICE_OUT_WIRED_HEADPHONE ||

               out_device & AUDIO_DEVICE_OUT_EARPIECE ||

               out_device & AUDIO_DEVICE_OUT_SPEAKER )
@@ -6112,8 +6114,10 @@ snd_device_t platform_get_input_snd_device(void *platform, 
    if (snd_device != AUDIO_DEVICE_NONE)

        goto exit;



    if ((out_device != AUDIO_DEVICE_NONE) && ((mode == AUDIO_MODE_IN_CALL) || voice_is_in_call(adev) ||

        voice_extn_compress_voip_is_active(adev) || audio_extn_hfp_is_active(adev))) {

    if ((out_device != AUDIO_DEVICE_NONE) && ((mode == AUDIO_MODE_IN_CALL) ||

        voice_check_voicecall_usecases_active(adev) ||

        voice_extn_compress_voip_is_active(adev) ||

        audio_extn_hfp_is_active(adev))) {

        if ((adev->voice.tty_mode != TTY_MODE_OFF) &&

            !voice_extn_compress_voip_is_active(adev)) {

            if (out_device & AUDIO_DEVICE_OUT_WIRED_HEADPHONE ||

hal/voice.c

+16 −0
Original line number Diff line number Diff line
@@ -377,6 +377,22 @@ uint32_t voice_get_active_session_id(struct audio_device *adev) 
    return session_id;

}



bool voice_check_voicecall_usecases_active(struct audio_device *adev)

{

    struct listnode *node;

    struct audio_usecase *usecase = NULL;



    list_for_each(node, &adev->usecase_list) {

        usecase = node_to_item(node, struct audio_usecase, list);

        if (usecase->type == VOICE_CALL) {

            ALOGV("%s: voice usecase:%s is active", __func__,

                   use_case_table[usecase->id]);

            return true;

        }

    }

    return false;

}



int voice_check_and_set_incall_rec_usecase(struct audio_device *adev,

                                           struct stream_in *in)

{

hal/voice.h

+1 −0
Original line number Diff line number Diff line
@@ -101,4 +101,5 @@ void voice_check_and_update_aanc_path(struct audio_device *adev, 
bool voice_is_call_state_active(struct audio_device *adev);

void voice_set_device_mute_flag (struct audio_device *adev, bool state);

snd_device_t voice_get_incall_rec_backend_device(struct stream_in *in);

bool voice_check_voicecall_usecases_active(struct audio_device *adev);

#endif //VOICE_H