Commit 8bba9e95 authored Nov 11, 2013 by Ravi Kumar Alamanda Committed by Vineeta Srivastava Nov 12, 2013

hal: Fix the audio loss issue on codec back end

- Start music playback, plug in and plug out headset and press
  'Next' button in the Music app immediately. Repeating these steps
  result complete loss of audio on HW codec.
- When headset is pluged out and Next is pressed immediately, the
  audio HAL triggers audio routing change from Headset to Speaker,
  and closure of compress playback driver. The later is not lock
  protected which result un protected access of back end information
  in the ALSA framework. This leads to incorrect routing and hence
  loss of audio. It is also observed that sometimes it could lead
  to crash in kernel and phone reboots.
- Fix by ensuring that the kernel driver close is also lock protected
  along with other routing events.

Bug: 11088400
Change-Id: I785effb09e5cef7ba20ee43e0ef91dc296d4e58a

parent a16217ce

hal/audio_hw.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1184,6 +1184,7 @@ static int out_standby(struct audio_stream *stream)

		pthread_mutex_lock(&out->lock);
		if (!out->standby) {
		pthread_mutex_lock(&adev->lock);
		out->standby = true;
		if (out->usecase != USECASE_AUDIO_PLAYBACK_OFFLOAD) {
		if (out->pcm) {
		@@ -1199,7 +1200,6 @@ static int out_standby(struct audio_stream *stream)
		out->compr = NULL;
		}
		}
		pthread_mutex_lock(&adev->lock);
		stop_output_stream(out);
		pthread_mutex_unlock(&adev->lock);
		}
		@@ -1673,12 +1673,12 @@ static int in_standby(struct audio_stream *stream)
		ALOGV("%s: enter", __func__);
		pthread_mutex_lock(&in->lock);
		if (!in->standby) {
		pthread_mutex_lock(&adev->lock);
		in->standby = true;
		if (in->pcm) {
		pcm_close(in->pcm);
		in->pcm = NULL;
		}
		pthread_mutex_lock(&adev->lock);
		status = stop_input_stream(in);
		pthread_mutex_unlock(&adev->lock);
		}