Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Updater does not support patch number

  • /e/ version: v1.0.2
  • Device model(s): ~"FP3/FP3+"

Summary

We cannot publish version with patch number like v1.0.2 where 2 is the patch number because the /e/OS Updates crashes.

The problem

Steps to reproduce

Have a build with a patch number and tap on the refresh button of the updater.

What is the current behavior?

The /e/OS Updates crashes.

What is the expected correct behavior?

The /e/OS Updates supports patch number.

Technical informations

Relevant logs (adb logcat)

--------- beginning of crash
06-21 08:52:06.536  5517  5517 E AndroidRuntime: FATAL EXCEPTION: main
06-21 08:52:06.536  5517  5517 E AndroidRuntime: Process: org.lineageos.updater, PID: 5517
06-21 08:52:06.536  5517  5517 E AndroidRuntime: java.lang.NumberFormatException: multiple points
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1914)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at sun.misc.FloatingDecimal.parseFloat(FloatingDecimal.java:122)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at java.lang.Float.parseFloat(Float.java:451)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at org.lineageos.updater.misc.Utils.checkForNewUpdates(Utils.java:279)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at org.lineageos.updater.UpdatesActivity.processNewJson(UpdatesActivity.java:326)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at org.lineageos.updater.UpdatesActivity.access$600(UpdatesActivity.java:75)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at org.lineageos.updater.UpdatesActivity$6.lambda$onSuccess$1$UpdatesActivity$6(UpdatesActivity.java:365)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at org.lineageos.updater.-$$Lambda$UpdatesActivity$6$N0a8nQdJ_byRZOxzn1AfTWoQm-s.run(Unknown Source:8)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:883)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:100)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:214)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:7356)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
06-21 08:52:06.536  5517  5517 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:940)
06-21 08:52:12.356  5517  5531 W System  : A resource failed to call close.

cc @rhunault