Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Migrate user theme preference to default light and use default color resource in month view

Amit Kumar requested to merge fix/2403 into master

Description

This MR is intended to fix a crash that happens if you already have dark/black theme enabled and user updates the apk with the latest ui-revamping change.

Related issues

e/backlog#2403 (closed)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related MRs

How has this been tested?

You can test by following these steps ->

  1. Install any old calendar version before UI-revamping changes.

  2. Set the theme to either dark/black in calendar app settings.

  3. Now install the apk built with the master branch of this project.

  4. Switch to "Month" view from the navigation drawer.

  5. It will result in a crash.

  6. Now install the apk built with this fix branch.

  7. Again try to switch to Month view and it should work with no crash.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Edited by Amit Kumar

Merge request reports

Loading